Skip to content

NO-SNOW: fix release test failure#4191

Merged
sfc-gh-aling merged 6 commits into
mainfrom
aling/fix-release-test-failures
Apr 22, 2026
Merged

NO-SNOW: fix release test failure#4191
sfc-gh-aling merged 6 commits into
mainfrom
aling/fix-release-test-failures

Conversation

@sfc-gh-aling

@sfc-gh-aling sfc-gh-aling commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aling sfc-gh-aling requested review from a team as code owners April 21, 2026 18:45
@github-actions

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@codecov-commenter

codecov-commenter commented Apr 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.18%. Comparing base (07689e0) to head (00e2f3b).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4191      +/-   ##
==========================================
- Coverage   95.42%   95.18%   -0.25%     
==========================================
  Files         171      171              
  Lines       43683    43786     +103     
  Branches     7475     7502      +27     
==========================================
- Hits        41685    41677       -8     
- Misses       1221     1314      +93     
- Partials      777      795      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sfc-gh-heshah
sfc-gh-heshah approved these changes Apr 21, 2026
View reviewed changes

@sfc-gh-heshah sfc-gh-heshah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we please still leave a TODO in the AST test driver to make some golden file improvements that enable storing source position information for multiple python versions.

@sfc-gh-aling sfc-gh-aling enabled auto-merge (squash) April 21, 2026 20:51
@sfc-gh-aling sfc-gh-aling requested a review from a team as a code owner April 22, 2026 01:03
@sfc-gh-aling sfc-gh-aling merged commit 0aeccd9 into main Apr 22, 2026
26 of 28 checks passed
@sfc-gh-aling sfc-gh-aling deleted the aling/fix-release-test-failures branch April 22, 2026 01:43
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-yuwang sfc-gh-yuwang sfc-gh-yuwang approved these changes

@sfc-gh-heshah sfc-gh-heshah sfc-gh-heshah approved these changes

@sfc-gh-joshi sfc-gh-joshi sfc-gh-joshi approved these changes

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-bkogan sfc-gh-bkogan sfc-gh-bkogan approved these changes

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-nkumar sfc-gh-nkumar Awaiting requested review from sfc-gh-nkumar sfc-gh-nkumar is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees

No one assigned

Labels

snowpark-pandas

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sfc-gh-aling @codecov-commenter @sfc-gh-yuwang @sfc-gh-heshah @sfc-gh-joshi @sfc-gh-helmeleegy @sfc-gh-bkogan